OpcodeDispatcher: Constexpr-ify all the tables possible #4073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This hasn't been necessary for quite a while as we handle invalid/unsupported opcodes in the frontend now.
Still track the telemetry if EVEX is attempted, but remove the tables which we won't be supporting.
Sonicadvance1
force-pushed
the
constexpr_all_tables
branch
2 times, most recently
from
5a6ede7 to
c4fd111
Compare
This was causing egregious stack usage in these two functions
Sonicadvance1
force-pushed
the
constexpr_all_tables
branch
from
c4fd111 to
dc2a265
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up from #4048, converts over the remaining tables to be constexpr